Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom share button only allows 1 class #11

Closed
stevewarsa opened this issue Nov 14, 2016 · 3 comments
Closed

Custom share button only allows 1 class #11

stevewarsa opened this issue Nov 14, 2016 · 3 comments
Assignees
Labels

Comments

@stevewarsa
Copy link

Thanks for developing this - it is really helpful. I found an issue that is not a show-stopper, but I would like to correct:

There does not appear to be a way to pass in more than 1 class into a custom share button. For example here is a custom method I've written:

getTwitterButton(): ShareButton {
let twitterButton = new ShareButton(
ShareProvider.TWITTER,
" Tweet",
'btn btn-primary'
);
return twitterButton;
}

This throws an error:

inline template:17:4 caused by: Failed to execute 'add' on 'DOMTokenList': The token provided ('btn btn-primary') contains HTML space characters, which are not valid in tokens

if I just put 'btn' it works fine.

How do I pass in multiple classes?

@MurhafSousli
Copy link
Owner

Hi @stevewarsa, Thanks for opening the issue, I will fix this and let you know when it's updated

@MurhafSousli MurhafSousli self-assigned this Nov 14, 2016
@MurhafSousli
Copy link
Owner

Changes are merged and pushed to npm 1.0.7

@stevewarsa
Copy link
Author

Thanks, I'll check it out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants