Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular IVY support #352

Closed
1 task done
tomgruszowski opened this issue Nov 25, 2018 · 1 comment · Fixed by #432
Closed
1 task done

Angular IVY support #352

tomgruszowski opened this issue Nov 25, 2018 · 1 comment · Fixed by #432
Labels
Milestone

Comments

@tomgruszowski
Copy link

I am submitting a

  • Bug Report

What is the current behavior?

While Ivy isn't 100% ready I wanted to let you know about this issue so you're aware of it. Feel free to close this issue if already aware of it.


ERROR in : Template parse errors:
The pipe 'shareCount' could not be found ("  <!-- BUTTON COUNT -->
    <div *ngIf="showCount && shareCount" class="sb-count">
      <span>{{ [ERROR ->]shareCount | shareCount }}</span>
    </div>

"): C:/.../node_modules/@ngx-share/button/ngx-share-button.d.ts.ShareButton.html@35:15

What are the steps to reproduce?

add this to tsconfig and try a prod build

"angularCompilerOptions": {
"enableIvy": true
}

What is the use-case or motivation for changing an existing behavior?

Ensure library is ready for Ivy compiler.

Which versions are you using for the following packages?

Latest ...
Angular: 7
Share buttons: 7

@MurhafSousli
Copy link
Owner

@tomgruszowski Thanks for the feedback! no lets keep this open until lvy is ready

@MurhafSousli MurhafSousli mentioned this issue Apr 3, 2020
@MurhafSousli MurhafSousli added this to the Version 8 milestone Apr 3, 2020
@MurhafSousli MurhafSousli mentioned this issue Apr 3, 2020
1 task
@MurhafSousli MurhafSousli changed the title Error when building with Ivy Angular IVY support Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants