Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention that 14.0.0 needs at least Angular 17.1.0, not only v17 #680

Closed
burnaDLX opened this issue Jul 9, 2024 · 1 comment · Fixed by #685
Closed

docs: mention that 14.0.0 needs at least Angular 17.1.0, not only v17 #680

burnaDLX opened this issue Jul 9, 2024 · 1 comment · Fixed by #685

Comments

@burnaDLX
Copy link

burnaDLX commented Jul 9, 2024

Reproduction

Steps to reproduce:

  1. Install Angular 17.0.x
  2. Try to use the ShareDirective

Expected Behavior

Should work with Angular v17.0.x or state otherwise in the release notes / docs.

Actual Behavior

The directive input expects a SignalInput, but SignalInputs were first introduced in 17.1.0.

Environment

  • Angular: 17.0.X
  • ngx-sharebuttons: 14.0.0
@burnaDLX burnaDLX changed the title v14 needs min. Angular 17.1.0 (which introduced SignalInputs) docs: mention that 14.0.0 needs at least Angular 17.1.0, not only v17 Jul 9, 2024
@MurhafSousli
Copy link
Owner

I guess you are right, I will correct that in the changelog, for Angular < 17.1.0 should use ngx-scrollbar@16

@MurhafSousli MurhafSousli linked a pull request Aug 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants