Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support plugin/preset definitions without prefixes in .babelrc #303

Closed
zdoc01 opened this issue Oct 29, 2016 · 5 comments · Fixed by #305
Closed

Support plugin/preset definitions without prefixes in .babelrc #303

zdoc01 opened this issue Oct 29, 2016 · 5 comments · Fixed by #305

Comments

@zdoc01
Copy link
Contributor

zdoc01 commented Oct 29, 2016

We currently cannot specify babel plugins and presets without the babel-* prefix in config/babel.js because of the way they are resolved. This is a standard convention that's highlighted in the babel docs for a given plugin or preset (see these babel-preset-react docs as an example).
zdoc01 added a commit to zdoc01/kyt that referenced this issue Oct 29, 2016
@zdoc01
Support plugin/preset definitions without prefixes in .babelrc (nytim…
f915b4b 
…es#303)
@zdoc01 zdoc01 mentioned this issue Oct 29, 2016
Merged
@zdoc01
Copy link
Contributor Author

zdoc01 commented Oct 30, 2016

It would also be awesome if this issue had a 'hacktoberfest' label :).

@tizmagik
Copy link
Contributor

Good catch, +1 from me on this issue 👍

@tizmagik
Copy link
Contributor

Although this might be moot depending on where we land with #250 / #134 but this might be good to get in in the mean time. @delambo thoughts?

@delambo
Copy link
Member

delambo commented Oct 30, 2016

You're right @tizmagik, this will most likely be moot when 0.4.0 comes out since we're leaning on the monorepo/babel plugin pull request that @jaredmcdonald is working on. Let's merge this change and release it in 0.3.1 in case users bump up against this problem in the interim.

@jaredmcdonald
Copy link
Contributor

we'll probably need to do something like this when we support user .babelrcs anyway, so I can port what @zdoc01 did here 👍

delambo pushed a commit that referenced this issue Nov 1, 2016
@zdoc01 @delambo
Support plugin/preset definitions without prefixes in .babelrc (#303) (…
e6a044f 
…#305)
zdoc01 added a commit to zdoc01/kyt that referenced this issue Nov 3, 2016
@zdoc01
Update unit tests for changes made to resolve nytimes#303
9c819f8
@zdoc01 zdoc01 mentioned this issue Nov 3, 2016
Merged
ccpricenytimes pushed a commit that referenced this issue Nov 4, 2016
@zdoc01 @ccpricenytimes
Update unit tests for changes made to resolve #303 (#318)
0c0bbd9
tizmagik added a commit that referenced this issue Dec 14, 2016
@tizmagik
Merge branch 'master' into yarn
229a078 
* master: (35 commits)
  creates local copies of packages so e2e tests use latest code (#345)
  adds style and script linter packages (#344)
  now using npm version to check for kyt-cli updates (#337)
  Adds kyt version option to setup command (#343)
  make lint-script command; lint now runs scripts and style (#339)
  Adds bootstrap scripts (#341)
  fixes test coverage command (#342)
  Run test from root directory (#336)
  Monorepo (#330)
  [ci skip] document Jest/Watchman issue and common workaround (#334)
  Catch SIGINT (#332)
  Fixes e2e tests (#326)
  Removes deprecated reflect eslint rule (#325)
  Upgrade Linter dependencies (#289)
  [doc]fix path of eslintrc and stylelintrc (#321)
  Update unit tests for changes made to resolve #303 (#318)
  adds ISSUE_TEMPLATE (#317)
  Adds rfc template (#316)
  document possible kyt setup repository url formats (#314)
  Overwrites default npm init test script on setup (#293)
  ...

# Conflicts:
#	.travis.yml
#	e2e_tests/tests/cli.test.js
#	package.json
#	packages/kyt-cli/cli/actions/setup.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support plugin/preset definitions without prefixes in .babelrc (#303) zdoc01/kyt
4 participants
@tizmagik @delambo @zdoc01 @jaredmcdonald