Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes e2e tests #326

Merged
merged 4 commits into from
Nov 18, 2016
Merged

Fixes e2e tests #326

merged 4 commits into from
Nov 18, 2016

Conversation

ccpricenytimes
Copy link
Contributor

some e2e tests were silently failing, this uses promises to make sure the assertions are reported properly

@delambo delambo merged commit 12945a9 into master Nov 18, 2016
@delambo delambo deleted the e2e-test-bugfix branch November 18, 2016 17:02
tizmagik added a commit that referenced this pull request Dec 14, 2016
* master: (35 commits)
  creates local copies of packages so e2e tests use latest code (#345)
  adds style and script linter packages (#344)
  now using npm version to check for kyt-cli updates (#337)
  Adds kyt version option to setup command (#343)
  make lint-script command; lint now runs scripts and style (#339)
  Adds bootstrap scripts (#341)
  fixes test coverage command (#342)
  Run test from root directory (#336)
  Monorepo (#330)
  [ci skip] document Jest/Watchman issue and common workaround (#334)
  Catch SIGINT (#332)
  Fixes e2e tests (#326)
  Removes deprecated reflect eslint rule (#325)
  Upgrade Linter dependencies (#289)
  [doc]fix path of eslintrc and stylelintrc (#321)
  Update unit tests for changes made to resolve #303 (#318)
  adds ISSUE_TEMPLATE (#317)
  Adds rfc template (#316)
  document possible kyt setup repository url formats (#314)
  Overwrites default npm init test script on setup (#293)
  ...

# Conflicts:
#	.travis.yml
#	e2e_tests/tests/cli.test.js
#	package.json
#	packages/kyt-cli/cli/actions/setup.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants