We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi there!
After adding magic_enum to my project I got unexpected build errors on some platforms in ci. But on some platforms build was successful.
magic_enum
I started looking into it and found out what was going on. In magic_enum std::get is extended https://github.com/Neargye/magic_enum/blob/master/include/magic_enum/magic_enum_containers.hpp#L1130. But с++ documentation states, that "It is undefined behavior to declare a full specialization of any standard library function template." (https://en.cppreference.com/w/cpp/language/extending_std section "Function templates and member functions of templates").
std::get
I suggest to define get for magic_enum in a separate namespace. Maybe you have other suggestions?
get
The text was updated successfully, but these errors were encountered:
Yes indeed, I think it’s worth leaving it in namespace magic_enum::containers
namespace magic_enum::containers
Sorry, something went wrong.
magic_enum::containers
Successfully merging a pull request may close this issue.
Hi there!
After adding
magic_enum
to my project I got unexpected build errors on some platforms in ci. But on some platforms build was successful.I started looking into it and found out what was going on. In
magic_enum
std::get
is extended https://github.com/Neargye/magic_enum/blob/master/include/magic_enum/magic_enum_containers.hpp#L1130. But с++ documentation states, that "It is undefined behavior to declare a full specialization of any standard library function template." (https://en.cppreference.com/w/cpp/language/extending_std section "Function templates and member functions of templates").I suggest to define
get
formagic_enum
in a separate namespace. Maybe you have other suggestions?The text was updated successfully, but these errors were encountered: