Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Screen brightness controls #92

Open
mikejgray opened this issue Jul 6, 2024 · 5 comments
Open

[FEAT] Screen brightness controls #92

mikejgray opened this issue Jul 6, 2024 · 5 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@mikejgray
Copy link

Objective

There should be intents to handle brightness controls on the Mark 2.

Initial Implementation Requirements

  • Screen On
  • Screen Off
  • Screen percentage 0-100%

Other Considerations

No response

@mikejgray mikejgray added enhancement New feature or request triage New issue needs review labels Jul 6, 2024
@NeonDaniel NeonDaniel added question Further information is requested and removed triage New issue needs review labels Jul 9, 2024
@NeonDaniel
Copy link
Member

Consider also a separate skill like the volume skill that only deals with screen controls.. I could see this integrating with the GUI and/or a PHAL plugin (i.e. dimming a matrix display like the Mark1) for the actual hardware interface

@builderjer
Copy link
Member

It could then support hdmi also

@JarbasAl
Copy link

JarbasAl commented Jul 9, 2024

the enclosure api defines a brightness control message (for the mk1, this was for eyes),
a skill for the enclosure API exists here https://github.com/OVOSHatchery/ovos-skill-mark1-ctrl , on my TODO to get it updated

the dimming is controlled by the shell companion plugin, we can probably unify the bus messages namespace and make the shell companion plugin respect the existing enclosure api

@JarbasAl
Copy link

JarbasAl commented Jul 9, 2024

It could then support hdmi also

also supported by the ovos-shell-companion plugin

@builderjer
Copy link
Member

But not with voice. Guess the skill should just emit a bus message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Other Helpful Tasks
Development

No branches or pull requests

4 participants