Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/GeopoliticalUnits return object #46

Open
stryker-m opened this issue Oct 9, 2017 · 2 comments
Open

data/GeopoliticalUnits return object #46

stryker-m opened this issue Oct 9, 2017 · 2 comments

Comments

@stryker-m
Copy link
Collaborator

data object returned by /v2/data/GeopoliticalUnits does not match /v1 data object which is: "data":[{"GeoPoliticalID":173,"GeoPoliticalName":"Antarctica"},{"GeoPoliticalID":264,"GeoPoliticalName":"Argentina"},...

@stryker-m stryker-m changed the title data/GeopoliticalUnits data/GeopoliticalUnits return object Oct 9, 2017
@SimonGoring
Copy link
Contributor

Is this an issue? I thought that by moving to v2 we were going to break some backwards compatibility.

currently:

http://api-dev.neotomadb.org/v2/data/geopoliticalunits/12

Returns

{
  "status": "success",
  "data": [
    {
      "geopoliticalid": 12,
      "geopoliticalname": "Helmand",
      "geopoliticalunit": "province (velayat)",
      "rank": 2,
      "highergeopoliticalid": 1,
      "recdatecreated": "2013-09-30T18:02:51.000Z",
      "recdatemodified": "2013-09-30T18:02:51.000Z"
    }
  ]
}

I think this is the most appropriate response (although a better one would possibly include some external reference, and use an external standard for the named elements, rather than Neotoma's specific terms).

Does this need to be changed in the v2 API, or can we move forward with the new standard?

@stryker-m
Copy link
Collaborator Author

There needs to be a minimal migrated API set that serves Explorer (and any other clients looking to view the most recent data). v2 can break the API but there needs to be a v1.5 that does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants