Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Web.HttpException Logged, but missing data #147

Open
seankearney opened this issue Sep 26, 2018 · 1 comment
Open

System.Web.HttpException Logged, but missing data #147

seankearney opened this issue Sep 26, 2018 · 1 comment

Comments

@seankearney
Copy link
Contributor

Requests such as /test<illegal.jpg throw a System.Web.HttpException exception

[HttpException (0x80004005): A potentially dangerous Request.Path value was detected from the client (*).]
   System.Web.HttpRequest.ValidateInputIfRequiredByConfig() +9939972
   System.Web.PipelineStepManager.ValidateHelper(HttpContext context) +53

Exceptional does catch these exceptions, but it is lacking information such as the actual Url. We can trace this down to https://github.com/NickCraver/StackExchange.Exceptional/blob/master/src/StackExchange.Exceptional/AspNetExtensions.cs#L145 where in this case the context.Handler == null.

image

@NickCraver
Copy link
Owner

The context.Handle == null check (proposed to remove in #148) causes other null refs on startup...but I'll have to find what those were.

We need a bit more info here to more finitely localize the null checks and get as much info as possible instead of bailing completely. I'll try and look back, but not sure I have the exact cause that 2fad0bc resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants