-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp tests #13
Comments
@Kawacrepe can I take this issue? |
Yes, feel free to ping me if some additionnals informations are needed :) |
@Kawacrepe Yes, I want to make sure I understood the task correctly. This is effectively removing the temp.js file after carefully transposing its logic into a unit test. In conclusion, should we also implement Rossbob's recommendations |
Exactly, we should look at the rossbob recommendations :) |
Going to rework them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our tests must be refacto, we must execute
temp.js
to create the nsecure-result.json which will be analyzed by the package.We want to remove this file and include the step in our tests.
The second improvement consist in what Rossbob told me in another PR
I would have added some tests over rewriting it :
but it may be overkill
Originally posted by @Rossb0b in #12 (review)
The text was updated successfully, but these errors were encountered: