Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not working with tests #27

Closed
facusapienza21 opened this issue Aug 8, 2023 · 2 comments
Closed

CI not working with tests #27

facusapienza21 opened this issue Aug 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@facusapienza21
Copy link
Member

Currently Huginn.jl has implemented the same workflow that is working in Sleipnir.jl to run the tests automatically after every commit to main. However, in Huginn this is not working, and the problem seems to be comming from PyCall. Observing both stacktraces, we observe that in Huginn it seems that the conda environmnet is not properly set:

Screen Shot 2023-08-08 at 11 02 48 AM

This error does't not show in Sleipnir. The problem is probably coming from the fact that here Sleipnir is being installed and imported as a separate module. Here is something in the PyCall documentation that may help find the solution.

Screen Shot 2023-08-08 at 11 04 35 AM

@facusapienza21 facusapienza21 added the bug Something isn't working label Aug 8, 2023
@JordiBolibar
Copy link
Member

Is this fixed now? I think we basically repeated the same workflow of Sleipnir inside Huginn in order to to pyimport to all necessary Python packages? Ideally, it would be nice to fix this and clean up this repetition.

To be seen if now that we do @reexport using Sleipnir this is fixed.

@JordiBolibar
Copy link
Member

I think for now we have reached a suitable solution. We can always re-open this if it becomes a problem again.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants