Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_mode to SimulationParameters #47

Open
JordiBolibar opened this issue Dec 18, 2023 · 0 comments
Open

Add test_mode to SimulationParameters #47

JordiBolibar opened this issue Dec 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JordiBolibar
Copy link
Member

We already have a test flag for some workflows to have specific configurations during tests. However, this should become more systematic, especially following recent issues during tests.

For example, there seems to be an issue when removing workers in GH CI. If there is first a test which uses 4 workers and then comes another one which asks only for 1 worker, the code is made in such a way that 3 workers will be removed. This works fine in local, but seems to crash in GH CI. By using that flag in the parameters, we could avoid removing workers when it test. Such idea could be re-used for many future issues like this.

@JordiBolibar JordiBolibar added the enhancement New feature or request label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant