Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator doesn't stop when it should #15

Open
konstin opened this issue Oct 3, 2017 · 4 comments
Open

Validator doesn't stop when it should #15

konstin opened this issue Oct 3, 2017 · 4 comments
Assignees

Comments

@konstin
Copy link
Member

konstin commented Oct 3, 2017

When pressing ctrl+c / ctrl+shift+c in the terminal, the application receives a keyboard interrupt. Most applications stop on the first or second time they receive that signal, but the validator just prints a stacktrace and caries on. Instead, the validator should abort on the first keyboard interrupt

@konstin konstin added the bug label Oct 3, 2017
@konstin konstin changed the title Validator doesn't when it should Validator doesn't stop when it should Oct 3, 2017
@eFrane eFrane self-assigned this Oct 3, 2017
@eFrane
Copy link
Member

eFrane commented Nov 29, 2017

This was a bug related to liboparl and has since been solved.

@eFrane eFrane closed this as completed Nov 29, 2017
@eFrane eFrane reopened this Dec 2, 2017
@eFrane
Copy link
Member

eFrane commented Dec 2, 2017

Unfortunately, this bug still exists. Whenever the validator can't exit cleanly,
it takes several SIGTERM signals to make it stop.

@konstin
Copy link
Member Author

konstin commented Dec 2, 2017

FYI this isn't specific to the validator but seems to be happening with python programs using liboparl, so it seems to be more of a liboparl than a validator bug.

@eFrane
Copy link
Member

eFrane commented Dec 8, 2017

There's issues with breaking out of the threads now.
These should be mitigatable by actually using some sort
of thread pool and listening to the SIGABRT/SIGKILL signals,
then we could "force-join" the running threads.

@eFrane eFrane added the backlog label Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants