Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable GH Actions for grass-addons #172

Closed
neteler opened this issue May 14, 2020 · 4 comments · Fixed by #205
Closed

[Feature] Enable GH Actions for grass-addons #172

neteler opened this issue May 14, 2020 · 4 comments · Fixed by #205
Assignees
Labels
enhancement New feature or request

Comments

@neteler
Copy link
Member

neteler commented May 14, 2020

To improve the software quality it would be nice to have GH Actions also in the grass-addons repo.

It might be derived from the settings currently defined in GRASS GIS release_branch_7_8:

https://github.com/OSGeo/grass/tree/releasebranch_7_8/.github/workflows

What do you think (@wenzeslaus)?

@neteler neteler added the enhancement New feature or request label May 14, 2020
@neteler
Copy link
Member Author

neteler commented May 27, 2020

May I merge

here? Of course I'd like to preserve authorship somehow...

@wenzeslaus
Copy link
Member

Unfortunately, this needs little more than just copy pasting the files, but I have similar code in other repos.

I can look at this, but it would be helpful, although not necessary, to have clear idea about what is happening on the current build server. Are the scripts in the repo up to date and complete? I looked at them once, but I was not really able to run them locally.

Also what do you think about testing against different versions? 7.8 branch, master, Ubuntu PPA, ...? Some more important than the others? Is master reasonable? Perhaps @landam and @hellik can add Windows builds?

BTW, co-authorship is recognized on GitHub (and possibly more universally) by Co-authored-by: name <name@example.com> at the end of the commit message (see GitHub:creating-a-commit-with-multiple-authors). I think preserving authorship is possible too, but not much relevant here where significant changes are needed anyway.

@hellik
Copy link
Member

hellik commented May 29, 2020

Also what do you think about testing against different versions? 7.8 branch, master, Ubuntu PPA, ...? Some more important than the others? Is master reasonable? Perhaps @landam and @hellik can add Windows builds?

what do you mean by adding windows builds? building GRASS? building addons?

is there any progress in compiling GRASS with cmake? maybe this would ease windows builds on gh action?

@wenzeslaus
Copy link
Member

...add Windows builds?

what do you mean by adding windows builds? building GRASS? building addons?

I guess both would be needed since there is no grass-dev package for Windows, right?

is there any progress in compiling GRASS with cmake?

There is, but there is no timeline either. On top of that, CMake is just part of the compilation. Please see OSGeo/grass#348 (CMake only, some Windows support in separate PRs).

maybe this would ease windows builds on gh action?

I don't know. People are using GitHub Actions with other things than CMake (msys, cygwin, ...), so it seems at least possible.

The Windows VMs on GitHub Actions support Windows Docker containers, so one could run the same environment locally if needed (instead of dealing with the VM there).

@wenzeslaus wenzeslaus linked a pull request Jun 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants