Replies: 4 comments
-
This is easy to do, basically to revert the changes I did to only select GGA. Thinking about it more though, we would need to add the message type, so that the lat/lon data can be easily selected in the downstream. It seems more convenient to add a data variable to store the message type, rather than separate out messages of different sources into different data variables (like Thoughts? |
Beta Was this translation helpful? Give feedback.
-
Great.
Yeah, that's what I was thinking (data variable storing the message type / code). |
Beta Was this translation helpful? Give feedback.
-
Circling back to this topic, and just wanted to know where things stand. Has the default GPS datagram been changed? I have a vague memory of a discussion about this in the last several weeks, but nothing concrete. Also, I spent a few minutes trying to navigate the code to figure out where this default is currently set, but was not successful. Could someone point me to a couple of relevant lines in the code? I assume that'd be in the class-redesign branch. Thanks. |
Beta Was this translation helpful? Give feedback.
-
I think I can now answer the first part of my question, about whether the default has changed. I didn't remember that there was an issue on this topic (#232); and from there I found PR #236 from Jan 19, which lists this change: "default NMEA to save all GGA GLL RMC sentences (which contain GPS data)". |
Beta Was this translation helpful? Give feedback.
-
Not sure this rises to the level of an issue yet, so I'm compiling some scattered discussions here.
I think it'd be great to be able to extract and preserve the source-sentence code (GGA, etc) of the GPS data used, for reference and R&D. I haven't looked at the code specifically to see how easy this would be. For now I'm just recording that wish here.
Beta Was this translation helpful? Give feedback.
All reactions