Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper general way to extract parachain inherent data #146

Closed
JoshOrndorff opened this issue Nov 22, 2023 · 1 comment
Closed

Proper general way to extract parachain inherent data #146

JoshOrndorff opened this issue Nov 22, 2023 · 1 comment

Comments

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Nov 22, 2023

Our validate block implementation relies on a function called extract_parachain_inherent_data.

Currently this function assumes that the parachain inherent will be first. This should be improved so that it can be anywhere in the block.

The trick is that we need some way to determine whether we have the right constraint checker variant even though the aggregate constraint checker is generic. Perhaps something like IsSubType would be useful.

@JoshOrndorff
Copy link
Contributor Author

Solved in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant