New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor claim button logic #1231

Closed

dewanshparashar opened this issue Oct 19, 2023 · 1 comment

Contributor

dewanshparashar commented Oct 19, 2023

Currently we have claim buttons in tx history row as well as pending tx cards, and we are maintaining 2 sets of duplicate logic for both.

Not in this PR, but we might want to group logic for both claim button in a custom component/hook?

Originally posted by @chrstph-dvx in #1219 (review)

Member

fionnachan commented Aug 28, 2024

this is obsolete because we don't have pending tx cards anymore, so the logic is only in 1 place

fionnachan closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment