Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum for transaction status #1448

Closed
fionnachan opened this issue Jan 18, 2024 · 1 comment
Closed

enum for transaction status #1448

fionnachan opened this issue Jan 18, 2024 · 1 comment

Comments

@fionnachan
Copy link
Member

we have hardcoded string statuses in the code base and usage like tx.status === 'pending'

we should create an enum for all transaction statuses
@fionnachan fionnachan mentioned this issue Jan 18, 2024
Merged
@fionnachan
Copy link
Member Author

revisit when needed

@fionnachan fionnachan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fionnachan