Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: estimated gas is occasionally wrong after switching chain #1498

Open
fionnachan opened this issue Feb 1, 2024 · 1 comment
Open

Bug: estimated gas is occasionally wrong after switching chain #1498

fionnachan opened this issue Feb 1, 2024 · 1 comment
Assignees

Comments

@fionnachan
Copy link
Member

On first loading, we show for gas:

  • loader
  • 0 ETH
  • actual amount

When switching network once:
For the source:

  • we show the proper amount
  • loader for a split second
  • proper amount again

For the destination:

  • we show the wrong amount
  • loader for a split second
  • proper amount (sometime it doesn't update to the proper amount)

If switching back and forth fast, source chain will show 0 ETH for gas

Originally posted by @chrstph-dvx in #1288 (review)

@chrstph-dvx
Copy link
Contributor

We probably want to cache depositTokenEstimateGas result (maybe with useSWR?)

@fionnachan fionnachan self-assigned this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants