Rename Module to avoid path conflict with Ethereum go-ethereum

[FeurJak]

Could the module for OffchainLabs go-ethereum be renamed (i.e. Optimism names their geth module l2geth) ?

It's currently under module github.com/ethereum/go-ethereum which means there will be path conflicts if you were trying to import both OffchainLabs go-ethereum & Ethereums go-ethereum.

[AnonJon]

We are running into this issue as well after the nitro upgrade and needing to run the forked geth client along side the geth client. Any work around?

[hkalodner]

@FeurJak @jongregis can this be solved by just naming the import ex. import arblog "github.com/ethereum/go-ethereum/log"?

[AnonJon]

@hkalodner it fails to download the module with the current geth module downloaded
go: downloading github.com/OffchainLabs/go-ethereum v0.0.0-20220901205353-ee7893f42e8e go: github.com/OffchainLabs/go-ethereum@v0.0.0-20220901205353-ee7893f42e8e: parsing go.mod: module declares its path as: github.com/ethereum/go-ethereum but was required as: github.com/OffchainLabs/go-ethereum

[hkalodner]

Good callout, we're looking into the best option here

[huahuayu]

@hkalodner it fails to download the module with the current geth module downloaded go: downloading github.com/OffchainLabs/go-ethereum v0.0.0-20220901205353-ee7893f42e8e go: github.com/OffchainLabs/go-ethereum@v0.0.0-20220901205353-ee7893f42e8e: parsing go.mod: module declares its path as: github.com/ethereum/go-ethereum but was required as: github.com/OffchainLabs/go-ethereum

same problem, it's 29-Nov, 2022 now...

[huahuayu]

@hkalodner please just rename the go module name to github.com/OffchainLabs/go-ethereum what preventing you to do this?

[roodeag]

@hkalodner Usually, developers of ethereum use "github.com/ethereum/go-ethereum" to develop ethereum-related projects, but since arbitrum is based on go-ethereum and has many new features, developers cannot use "github.com/ethereum/go-ethereum" directly. Since arbitrum is based on go-ethereum, developers cannot use the library "github.com/ethereum/go-ethereum" directly for normal development, such as tracking blocks. In view of this, I sincerely hope that the arbitrum team will pay attention to this problem and fix it, the solution is to change the name of go-module.

Until arbitrum fixes this issue, you can use this https://github.com/roodeag/arbitrum that I modified

[grallc]

10 months later, issue still occurring.
Quite annoying as I'd like to build a project that handles both Arbitrum and Mainnet transactions but it's just not doable, as go-ethereum returns transaction type not supported with Arbitrum transactions, but I can't install Arbitrum's client.

[byte-bandit]

We also really need support for this. @hkalodner What is your plan for this issue going forward?

[anhthii]

Hello, any updates on this? We face a situation when we need to run both go-ethereum and Arbitrum go-ethereum in the same application to avoid transaction type not supported issue. Thank you!

[eprokhor]

+1 Bumping

[aemet93]

Same. Any plans to fix this?