Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.x reaches the end of life by the end of 2018 #1246

Closed
wing328 opened this issue Oct 15, 2018 · 8 comments
Closed

PHP 5.x reaches the end of life by the end of 2018 #1246

wing328 opened this issue Oct 15, 2018 · 8 comments

Comments

@wing328
Copy link
Member

wing328 commented Oct 15, 2018

Description

PHP 5.x reaches the end of life by the end of 2018 so we need to upgrade our PHP clients, servers to use PHP 7.x as the default.

Ref: http://php.net/supported-versions.php

openapi-generator version

I suggest we do it as part of the 4.0.0 release (next major release)

Suggest a fix/enhancement

If anyone wants to help on this, please reply to let us know.

@wing328
Copy link
Member Author

wing328 commented Oct 16, 2018

cc @jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09) @ackintosh (2017/09) @ybelenko (2018/07)

@ackintosh
Copy link
Contributor

There are worthwhile challenges ✨:

  • Replace deprecated stuffs
  • Apply new features
  • Update dependencies

PHP: Migrating from PHP 5.6.x to PHP 7.0.x - Manual

@ybelenko
Copy link
Contributor

ybelenko commented Oct 17, 2018

I'm working on PHP Slim refactoring descripted in #426. In short it's separating generated stubs from user implementation. I'm quite sure that it will be breaking changes without fallback, so maybe we should include both migration to 7.0.x and interfaces/implementation refactoring to the next release?

@ackintosh @wing328 Does it sounds right to you? Should I address both PRs to 4.0.0?

@ybelenko ybelenko mentioned this issue Oct 17, 2018
4 tasks
@ackintosh
Copy link
Contributor

Thanks for your great work. It sounds good to me. 👍

@jacobweber
Copy link
Contributor

The php README still says "Requirements: PHP 5.5 and later"

@wing328
Copy link
Member Author

wing328 commented Apr 3, 2019

@jacobweber good catch. Do you mind filing a PR to update it (template)?

@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019
@wing328 wing328 modified the milestones: 4.1.1, 4.1.2 Aug 26, 2019
@wing328 wing328 modified the milestones: 4.1.2, 4.1.3 Sep 11, 2019
@wing328 wing328 modified the milestones: 4.1.3, 4.2.0 Oct 4, 2019
@wing328 wing328 removed this from the 4.2.0 milestone Oct 30, 2019
@arderyp
Copy link

arderyp commented Feb 28, 2020

So this issue is still out there. Any hopes of addressing it soon? 5 is long gone by now.

I tried using the phpLegacySupport options, but it seems to do nothing when using the php generator, despite actually producing more strongly typed code when using the php-symfony generator (see this)

EDIT: see #5480

@ybelenko
Copy link
Contributor

ybelenko commented May 5, 2020

Current progress of migration to PHP 7.x:

generator README.md composer.json @phpdoc
php-client
php-laravel
php-lumen
php-slim
php-slim4
php-symfony
php-ze-ph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants