[BUG] [axios-typescript] header values configured via Configuration#baseOptions are dropped

[johannes-darms]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator
• What's the version of OpenAPI Generator used?
• Have you search for related issues/PRs?
• What's the actual output vs expected output?

Description

Custom headers set via baseOptions of a Configuration object are not present in the axios request. Expected behaviour: they are present ;).

openapi-generator version

4.1.2

OpenAPI declaration file content or url

any, can be used

Command line used for generation

any, can be used

Steps to reproduce

Pass this Configuration to a *AxiosParamCreator, the axios request should contain the custom header but is doesn't.

new Configuration({
        baseOptions: {
          headers: {
            'x-CUSTOM-VALUE': `xxx`,
          },
        },
      })

Related issues/PRs

Suggest a fix

johannes-darms@cd12d42

[macjohnny]

I think the problem is that

openapi-generator/samples/client/petstore/typescript-axios/builds/default/api.ts

Line 294 in b69b8cd

localVarRequestOptions.headers = {...localVarHeaderParameter, ...options.headers};

should be changed to something like

localVarRequestOptions.headers = {
  ...localVarHeaderParameter, 
  ...options.headers,
  ...(baseOptions ? baseOptions.headers : {})
};

@johannes-darms would you like to implement and test this fix in

openapi-generator/modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache

Line 191 in b69b8cd

localVarRequestOptions.headers = {...localVarHeaderParameter, ...options.headers};

?

[macjohnny]

the suggested fix johannes-darms@cd12d42 looks good
would you like to file a PR?

[johannes-darms]

the suggested fix johannes-darms@cd12d42 looks good
would you like to file a PR?

sure.

[jonathan-avento]

What is the status of this, was a PR ever created?

[joshlang232]

It looks like this commit fixes the issue: a4fc319

It seems safe to close this issue as a duplicate of #5420