Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][typescript-axios] modelPropertyNaming generator config default should be original, not camelCase #5592

Closed
5 of 6 tasks
ceefour opened this issue Mar 14, 2020 · 2 comments

Comments

@ceefour
Copy link

ceefour commented Mar 14, 2020

UPDATE: I just realized that #5427 is quite recent, and was not included in v4.2.3. I'd expect v4.2.4 will already resolve this bug.

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you search for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

modelPropertyNaming generator config default should be original, not camelCase: (see #5427, https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/typescript-axios.md)

openapi-generator config-help -g typescript-axios

CONFIG OPTIONS

        allowUnicodeIdentifiers
            boolean, toggles whether unicode identifiers are allowed in names or not, default is false (Default: false)

        ensureUniqueParams
            Whether to ensure parameter names are unique in an operation (rename parameters that are not). (Default: true)

        enumPropertyNaming
            Naming convention for enum properties: 'camelCase', 'PascalCase', 'snake_case', 'UPPERCASE', and 'original' (Default: PascalCase)

        modelPropertyNaming
            Naming convention for the property: 'camelCase', 'PascalCase', 'snake_case' and 'original', which keeps the original name (Default: camelCase)
...
openapi-generator version

4.2.3

OpenAPI declaration file content or url

any

Command line used for generation

see Description

Steps to reproduce

see Description

Related issues/PRs

#5427

Suggest a fix

change the default in typescript-axios generator, modelPropertyNaming to original, as properly documented: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/typescript-axios.md

@auto-labeler
Copy link

auto-labeler bot commented Mar 14, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@ceefour
Copy link
Author

ceefour commented Mar 14, 2020

UPDATE: I just realized that #5427 is quite recent, and was not included in v4.2.3. I'd expect v4.2.4 will already resolve this bug.

@ceefour ceefour closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant