Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Properties should calculate Partial Charges or hide the column #1471

Closed
ghutchis opened this issue Nov 25, 2023 · 6 comments · Fixed by #1502
Closed

Atom Properties should calculate Partial Charges or hide the column #1471

ghutchis opened this issue Nov 25, 2023 · 6 comments · Fixed by #1502
Labels

Comments

@ghutchis
Copy link
Member

Right now, if no partial charges are calculated, the partial charge column is 0.0, which is incorrect.

I think there are possible solutions:

  • hide the partial charge column if no charges have been calculated
  • use the first possible charge model to display something (e.g., check when setMolecule() is called)
  • (both) e.g., if no charges are calculated and no model is available
@ghutchis ghutchis added the bug label Nov 26, 2023
@Surajjalpun2002
Copy link
Contributor

I did a weird fix where i moved the partial charge column to the last and when no charges have been calculated, the number of columns reduces to 7 from 8. But when it finds some type of partial charge is calculated it increases it back to 8 essentially rendering the partial charge column at the last.
Screenshot from 2023-12-05 01-52-22
Screenshot from 2023-12-05 01-53-12

@Surajjalpun2002
Copy link
Contributor

i wanted to try the other solution where i force the calculation of some type of partial charge when atom properties are called but i have no idea how to go about that right now. Would you be able to point me in some direction here?

@ghutchis
Copy link
Member Author

ghutchis commented Dec 5, 2023

It looks like it's adding partial charge number to the color column.

@Surajjalpun2002
Copy link
Contributor

Yeah gotta fix that too.

@ghutchis ghutchis linked a pull request Dec 5, 2023 that will close this issue
@Surajjalpun2002
Copy link
Contributor

Is it issue solved? or is there something still to be done here?

@ghutchis
Copy link
Member Author

ghutchis commented Dec 5, 2023

I think for now, this is fixed, thanks.

@ghutchis ghutchis closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants