Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

details and summary HTML tag support #2038

Open
sjehuda opened this issue May 31, 2024 · 1 comment
Open

details and summary HTML tag support #2038

sjehuda opened this issue May 31, 2024 · 1 comment
Assignees
@sizzlemctwizzle
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. intended behavior "It's a feature not a bug." mightfix Ehh maybe... convince us all...

Comments

@sjehuda
Copy link

sjehuda commented May 31, 2024 •
edited
Loading

What happened?

This code works only upon preview.

<details>
</details>

What did you expect to happen?

Not collapsed

Click to see what happens.

What the problem might be?

No response
@sjehuda sjehuda added the bug You've guessed it... this means a bug is reported. label May 31, 2024
@Martii Martii added intended behavior "It's a feature not a bug." migration Use this to indicate that it may apply to an existing or announced migration. mightfix Ehh maybe... convince us all... and removed bug You've guessed it... this means a bug is reported. migration Use this to indicate that it may apply to an existing or announced migration. labels May 31, 2024
@Martii
Copy link
Member

Martii commented May 31, 2024 •
edited
Loading

As I mentioned at https://openuserjs.org/garage/Markdown_doesnt_work_inside_spoiler_tags.#comment-18bb7b3497e the details and summary tag are currently unsupported.

I had a conversation with @sizzlemctwizzle a while back where he wanted certain things allowed vs not allowed. At that time those two tags weren't in the GH arsenal of allowed... however they obviously are now.

My only concern is that someone will have to click all the little arrows in case someone spams things inside the "spoiler" as that account calls this... although not sure that will be a huge issue unless it is made one and then we could just remove the feature.

Anyhow I'll leave it open for @sizzlemctwizzle to recomment on publicly since he's the deciding factor here for the allow list of html tags during sanitizing.

@Martii Martii changed the title Details HTML tag work only upon preview details and summary HTML tag support May 31, 2024
@Martii Martii added the enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sizzlemctwizzle sizzlemctwizzle

Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. intended behavior "It's a feature not a bug." mightfix Ehh maybe... convince us all...
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sizzlemctwizzle @Martii @sjehuda