You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed some "repeated" queries when generating some test pages.
As the system has to build menus, if the same menu is configured in more places in the page (e.g. in more than one widget in different zones) some providers will repeat the queries they use to fetch the relevant information.
The "culprits" we found so far are:
DefaultMenuProvider that fetches again the list of MenuParts
They are different/unrelated.
This one is at a "higher level", in a sense. These providers should be repeating operations they don't need.
The other issue is deeper, and I think it should be handled transparently from whatever modules are doing.
We noticed some "repeated" queries when generating some test pages.
As the system has to build menus, if the same menu is configured in more places in the page (e.g. in more than one widget in different zones) some providers will repeat the queries they use to fetch the relevant information.
The "culprits" we found so far are:
DefaultMenuProvider
that fetches again the list ofMenuPart
sOrchard/src/Orchard.Web/Core/Navigation/Services/DefaultMenuProvider.cs
Line 9 in 610b3c4
TaxonomyNavigationProvider
that fetches again the list of terms.Orchard/src/Orchard.Web/Modules/Orchard.Taxonomies/Navigation/TaxonomyNavigationProvider.cs
Line 16 in 610b3c4
Both this situations can be fixed easily by memorizing the results of the first pass.
A PR for this is coming.
The text was updated successfully, but these errors were encountered: