Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong plot_goodness_of_fit if different order of rows in measurement_df and simulation_df #247

Open
plakrisenko opened this issue Feb 27, 2024 · 1 comment
Labels
bug Something isn't working visualization

Comments

@plakrisenko
Copy link
Collaborator

plakrisenko commented Feb 27, 2024

Currently there is no check in plot_goodness_of_fit that rows in measurement_df and simulation_df correspond to each other. And if they do not it messes up the plot.

For example, for the Isensee model from the benchmark collection

Wrong plot:
residuals_vs_simu

Correct plot:
residuals_vs_simu

@dweindl dweindl added the bug Something isn't working label Apr 19, 2024
@plakrisenko
Copy link
Collaborator Author

Actually, the second plot was still wrong 😄
residuals_vs_simu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visualization
Projects
None yet
Development

No branches or pull requests

2 participants