Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of extensions #273

Open
dweindl opened this issue Jun 25, 2024 · 2 comments
Open

Integration of extensions #273

dweindl opened this issue Jun 25, 2024 · 2 comments

Comments

@dweindl
Copy link
Member

dweindl commented Jun 25, 2024

With PEtab v2 we will introduce extensions to PEtab that will add new functionality. (In exceptional cases, extensions might also change some existing rules, but this is for another issue). For example, there is petab-select for model selection, units support for PEtab, and there were discussions to move the petab v1 visualization functionality to an extension.

Ideally, those extensions would be able to extend the current PEtab validator. Possibly they would also want to extend the petab.Problem API. Not sure what else.

The question is, whether those extensions should be directly incorporated here in libpetab, or whether we provide some plugin mechanism (via pluggy?). Currently, I'd prefer the latter, to avoid bloating this library and allow for mostly independent development of the extensions. However, this might make it difficult to handle any interaction of extensions. Happy to discuss other options and relevant points for plugins to modify libpetab behaviour.

@dilpath
Copy link
Member

dilpath commented Jun 25, 2024

What kinds of interactions between extensions might be difficult to support via a plugin system?

If there are currently no cases, then I'm also in favor of the plugin system.

@dweindl
Copy link
Member Author

dweindl commented Jun 25, 2024

What kinds of interactions between extensions might be difficult to support via a plugin system?

I don't have anything specific in mind. I hope extensions will be rather orthogonal.

If there are currently no cases, then I'm also in favor of the plugin system.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants