Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mPDF 7.x #144

Closed
KacerCZ opened this issue Apr 27, 2017 · 2 comments
Closed

Support for mPDF 7.x #144

KacerCZ opened this issue Apr 27, 2017 · 2 comments

Comments

@KacerCZ
Copy link
Contributor

KacerCZ commented Apr 27, 2017

Hi,
fix of issue #37 used class \Mpdf\Mpdf.
Later pull request #76 changed used class to \Mpdf.

mPDF up to version 6.1 uses class \mPDF.
From version 7.0 was added namespace and main class was renamed to \Mpdf\Mpdf, see https://github.com/mpdf/mpdf/blob/development/CHANGELOG.md

Is would be great if both versions could be supported, because mPDF 6.1 will not get support for PHP 7.1.

@PowerKiKi
Copy link
Member

Thank you for the clarification. Clearly going back to non-namespaced code was a mistake. It should not have been merged that way.

Support for mPDF 6 must be dropped in favor of mPDF 7. Because mPDF 7 support all the same PHP versions as us. And we really don't have the resource to support two different versions.

Would you be able to submit a PR for that ?

@KacerCZ
Copy link
Contributor Author

KacerCZ commented May 1, 2017

PR with fix is here - #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants