-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sampling extension support to PRQL #4425
Comments
I really like this idea, it could come in handy! I wondered if it would be possible to approximate this using a PRQL function; that might allow you to try it out before it's implemented natively within PRQL. I put this function together which works! (sorta... see below)
This outputs the following SQL: WITH table_0 AS (
SELECT
*
FROM
invoices USING SAMPLE 20
)
SELECT
customer_id
FROM
table_0
-- Generated by PRQL compiler version:0.11.3 (https://prql-lang.org) However, I start to get strange errors if I modify the pipeline preceding the
Perhaps I'm using the S-string wrong somehow... does anyone have suggestions? |
@kgutwin great use of s-strings! The one change to fix that error is: let sample = func
- nrows <float>
+ nrows <int>
tbl <relation>
-> <relation> (
from s"SELECT * FROM {tbl} USING SAMPLE {nrows}"
) I agree Would be very open to a PR for either! |
We need to do a survey of supported features in these databases and come up with an interface that will allow (eventually) supporting all of those features. |
What's up?
It would be great to handle table sampling in PRQL.
Examples:
The text was updated successfully, but these errors were encountered: