New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify unit test by paddle_test_util static lib #1059

Closed

tianbingsz opened this issue Jan 3, 2017 · 1 comment

Assignees

Contributor

tianbingsz commented Jan 3, 2017

We need to simplify unit test a little bit by adding paddle_test_util static lib. This is a supporting work to #1003 and #1009

The possible gains could be:

For example, in add paddle functions for Matrix ContextProjection APIs #1009,
add_unittest(ContextProjectionOpTest
ContextProjectionOpTest.cpp
../gserver/tests/TestUtil.cpp)
could be simplified as add_simple_unittest(ContextProjectionOpTest).
In gserver/tests/CMakeLists.txt, we could remove the dependency of TestUtil.cpp in many unit tests.

tianbingsz self-assigned this

Contributor Author

tianbingsz commented Jan 3, 2017

Please refer to PR #1058

tianbingsz assigned tianbingsz and unassigned tianbingsz

tianbingsz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment