Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scheduledData more accessible from block data #379

Open
SebastienGllmt opened this issue May 29, 2024 · 1 comment
Open

Make scheduledData more accessible from block data #379

SebastienGllmt opened this issue May 29, 2024 · 1 comment

Comments

@SebastienGllmt
Copy link
Contributor

Right now scheduledData and submittedData are treated differently. Some of the differences are a bit odd to explain though and it may be worth thinking about how to unify them a bit.

The disparity to address in this issue is that

  • submittedData is part of the block data (therefore, an explorer for example could be able to show all the submittedData for a given block easily). In fact, internalEvents is also part of the block data
  • scheduledData is, however, not part of the block data. Instead, it is fetched using getScheduledDataByBlockHeight and there it isn't accessible from outside of the process function in paima-sm

If we want to build an explorer, we should figure out how to address this. My feeling is probably scheduledData should be fetched outside of the process function and added to the ChainData type.

@acedward
Copy link
Contributor

Merging both lists submittedData and scheduledData sounds good for consistency and in the future run them in the parallel STF. But this will not persist the scheduledData information for an explorer, we will need to also store them somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants