Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to submit this 404 standard to the EIPs repo? #29

Open
sorawit opened this issue Feb 17, 2024 · 2 comments
Open

Any plan to submit this 404 standard to the EIPs repo? #29

sorawit opened this issue Feb 17, 2024 · 2 comments

Comments

@sorawit
Copy link

sorawit commented Feb 17, 2024

I'm curious whether Pandora team plans to submit this hybrid ERC20+ERC721 standard to the EIPs repository. Currently, there's some confusion about the final function interfaces and events, as well as the rationale behind them (some of which have changed from the legacy implementation). Without an official standard, it becomes particularly challenging for other projects to, for instance, implement their own 404 smart contracts with different performance tradeoffs while ensuring consistency with the specification. Also difficult for wallets, indexers and exchanges to know what data to read.

In the current codebase, the event Transfer(...) and event Approval(...) have been completely removed. Do we expect Etherscan, wallets, and other indexers to track the new ERC20Transfer, ERC20Approval, ERC721Transfer, etc., events? Otherwise I don't think token balances won't show on Web3 wallets / and contract won't be recognized as token on Etherscan.

I'm willing to assist with the draft if there are plans to proceed. Any information would be greatly appreciated.

@sorawit
Copy link
Author

sorawit commented Feb 17, 2024

Seems like a merge ~2 hours ago just changed the spec #17 for events back to be the conflicting signatures again. Having spec would be great!

@0xacme
Copy link
Contributor

0xacme commented Feb 20, 2024

Getting there 👍

I'll leave this open for the time being as it does deserve visibility. Just want to acknowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants