Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming StatusEffect -> StatusEffectType, StatusEffectInstance -> StatusEffect #480

Open
supersaiyansubtlety opened this issue Aug 13, 2023 · 0 comments
Labels
discussion changes that need discussion before being implemented

Comments

@supersaiyansubtlety
Copy link
Contributor

  1. similar to EntityType+Entity

  2. I think it makes more sense to use the StatusEffect name for the thing more closely tied to what you see/experience in game (banner with timer/results of the effect for the duration)

  3. I think use of the word Instance should be avoided because it's [redundant+could cause confusion] with instantiation in OOP (except for singleton constants that are just INSTANCE).

@supersaiyansubtlety supersaiyansubtlety changed the title Consider renaming StatusEffect -> StatusEffectType, StatusEffectInstance -> StatusEffect Consider renaming StatusEffect -> StatusEffectType, StatusEffectInstance -> StatusEffect Sep 2, 2023
@supersaiyansubtlety supersaiyansubtlety added the discussion changes that need discussion before being implemented label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion changes that need discussion before being implemented
Projects
None yet
Development

No branches or pull requests

1 participant