Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope notes, examples, in domain/range of #121

Open
VladimirAlexiev opened this issue Apr 15, 2021 · 1 comment
Open

scope notes, examples, in domain/range of #121

VladimirAlexiev opened this issue Apr 15, 2021 · 1 comment

Comments

@VladimirAlexiev
Copy link

Related to #108 and euBusinessGraph/eubg-data#18, below is a list of the omissions of PyLODE compared to my patched LODE.

When euBusinessGraph/eubg-data#18 is fixed, the links below will be broken, but we'll keep the PyLODE example at https://github.com/euBusinessGraph/eubg-data/blob/master/ontology/pylode/doc.html.


Class WebResource

Class RegisteredOrganization:

Property adminUnitL3

Property identifier

@nicholascar
Copy link
Member

  • I've changes "Usage Note" to "Scope Notes everywhere
    • better reflects the underlying SKOS property
  • I've added Markdown support for properties

One of the issues with your examples above is that you are using http://schema.org but you should be using https://schema.org! In discussion with the schema.org people (@danbri) I've been only allowing the HTTPS version of schema.org everywhere, such as in RDFlib itself, not just pyLODE.

I've added an example of your EGB ontology to pyLODE's schedule of ontologies:

I've made two changes to the RDF:

  1. Used HTTPS for schema.org
  2. Ensured correct Markdown

With the first change, you can see domainIncludes, rangeIncludes for properties and the references to them for classes.

Regarding the multiple values for scos:scopeNote and example: no I haven't added support for multiple values yet, so best would just be to concatenate that text if you can. Now that there's Markdown support for those fields, this should be easy to do.

(you could put in a separate issue/PR to just deal with multiple filed values if you really must have them)

Also note that the skos:example fields use monospace so you can put in RDF code examples like this one:

There has to be a place for RDF examples, so we've chosen skos:example for it so plain text in other examples will have to do in other fields, like skos:scopeNote or just the main descriptions/definitions.

@VladimirAlexiev can you see now many of your issues this solves? Perhaps you can close this ticket if it solves lots and raise other ones for remaining problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants