Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_marker no longer available in pytest 4.0.0 #24

Closed
greenpasta opened this issue Sep 6, 2018 · 2 comments
Closed

get_marker no longer available in pytest 4.0.0 #24

greenpasta opened this issue Sep 6, 2018 · 2 comments
Labels
compatibility Issues about compatibility with libraries or other packages
Milestone

Comments

@greenpasta
Copy link

greenpasta commented Sep 6, 2018

I'm getting the following deprecation warnings using pytest-dependency 0.3.2 with pytest 3.8.0:

/usr/local/venv/pytest/lib64/python3.6/site-packages/pytest_dependency.py:150: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  depends = marker.kwargs.get('depends')
/usr/local/venv/pytest/lib64/python3.6/site-packages/pytest_dependency.py:139: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  name = marker.kwargs.get('name') if marker is not None else None
@RKrahl
Copy link
Owner

RKrahl commented Sep 6, 2018

Thanks for raising this! I will have to look into it. It may take some time.

@deepbrook
Copy link

deepbrook commented Nov 16, 2018

PR #25 should fix this!

@RKrahl RKrahl added this to the 0.3.3 milestone Nov 18, 2018
@RKrahl RKrahl modified the milestones: 0.3.3, 0.4 Dec 2, 2018
@RKrahl RKrahl closed this as completed in 3425197 Dec 2, 2018
@RKrahl RKrahl added the compatibility Issues about compatibility with libraries or other packages label Dec 2, 2018
@RKrahl RKrahl changed the title Deprecation warnings on pytest 3.8.0 get_marker no longer available in pytest 4.0.0 Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues about compatibility with libraries or other packages
Projects
None yet
Development

No branches or pull requests

3 participants