Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian roc-smi manpage for review #92

Open
Maxzor opened this issue Jan 30, 2022 · 2 comments
Open

Debian roc-smi manpage for review #92

Maxzor opened this issue Jan 30, 2022 · 2 comments

Comments

@Maxzor
Copy link

Maxzor commented Jan 30, 2022

Dear rocm-smi-lib maitainers,
Please review and suggest any correction before upload on this manpage.
It is a merge of the output of roc-smi --help and the README.md .

In particular if you would like any personal author to be cited.

If you find it welcome, in order to streamline future updates, I can submit a comprehensive PR on the README that would help a lot the production of future man pages here.

@kentrussell
Copy link
Contributor

kentrussell commented Feb 22, 2022

We have a bit of a change coming up regarding some of the wording in the disclaimer (see #97) and I'd rather that be incorporated into any man page, but I definitely have no issue with the work you've done there. If you want to submit the PR here, we can review here and then merge it internally and get it aligned with the work you guys are doing over there. Thanks!
EDIT: Is #91 the PR you're referencing? Or is there a bigger one incoming?

@ppanchad-amd
Copy link

@Maxzor Can we close this ticket? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants