Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLC fails to rotate vertical video from smartphone #106

Open
Botspot opened this issue Mar 24, 2024 · 7 comments
Open

VLC fails to rotate vertical video from smartphone #106

Botspot opened this issue Mar 24, 2024 · 7 comments

Comments

@Botspot
Copy link

Botspot commented Mar 24, 2024

This is a standard vertical video taken from a smartphone.
https://drive.google.com/file/d/1Czpn4BOzt3GpAwljFzMN83GO2elWYce_/view?usp=sharing
I am fairly sure that these used to play correctly on VLC. It uses the right dimensions of a vertical video, but the video itself was not rotated to match, causing it to be stretched.

Expected playback result: (Playing the same video after converting it to MP4)
20240323_19h36m02s_grim
Actual playback result:
20240323_19h34m05s_grim

Command line output:

pi@raspberrypi:~ $ vlc /home/pi/Downloads/IMG_3964.MOV
VLC media player 3.0.20 Vetinari (revision 3.0.20-0-g6f0d0ab126b)
[000000558102e560] main libvlc: Running vlc with the default interface. Use 'cvlc' to use vlc without interface.
[h264_v4l2m2m @ 0x7f68c4d120] Could not find a valid device
[h264_v4l2m2m @ 0x7f68c4d120] can't configure decoder
[0000007f68c23870] avcodec decoder error: cannot start codec (h264_v4l2m2m)
[0000007f500013f0] wl_dmabuf vout display: <<< Open: I420 1920x1090(1920x1080 @ 0,0 0/0), cfg.display: 1080x1920, source: 1920x1090(1920x1080 @ 0,0 1/1)

To reproduce: Download the file from the Google Drive link. Open it in VLC on PiOS Bookworm. Not sure how long ago this issue has existed. It may have predated the release of Bookworm.

@Botspot Botspot changed the title Stretches and fails to rotate vertical video VLC fails to rotate vertical video from smartphone Mar 24, 2024
@Botspot
Copy link
Author

Botspot commented May 19, 2024

This now appears to be working.
It may have been an update that fixed this, or as a result of my switching from Wayfire to LabWC.

@jc-kynesim
Copy link

Possibly both. I did fix various scaling & rotation issues in the last patch, but they did also require the underlying systems to support the rotation.

@ykharuzhy
Copy link

Does drm_vout video driver support rotation? I have met the same issue when playing video without of X Window and it still exists at last VLC.

@popcornmix
Copy link

DRM does not have rotation support.

@jc-kynesim
Copy link

Or to be slightly more accurate (though no more useful), DRM (the API) does support rotation and so does drm_vout however our HVS DRM kernel driver doesn't support 90 or 270 degree rotation (it will do 180). This is due to the HVS not supporting it directly. MMAL/OMX did support 90 degree rotation but the extra h/w block required to do that isn't available to the HVS DRM driver.

@ykharuzhy
Copy link

As I remember, ffplay plays video in correct orientation. It rotates it by software?

@jc-kynesim
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants