Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Leader #42

Open
fosytherrac opened this issue Feb 7, 2023 · 5 comments
Open

Disable Leader #42

fosytherrac opened this issue Feb 7, 2023 · 5 comments

Comments

@fosytherrac
Copy link

fosytherrac commented Feb 7, 2023

Is there a way to disable the "Leader"?

I want everyone to be able to Stop and Play without being the "Leader".
This is the reason my friends wont use it :(

If there isnt, is there a way you could implement such a feature that can turn on/off the "Leader" control? (via environment variable or toggle switch)

@RblSb
Copy link
Owner

RblSb commented Feb 8, 2023

You can try {"requestLeaderOnPause": true} in user/config.json, so every play/pause event will give/remove leader automatically.
Because of browser limitations, you cannot detect if pause is triggered by player interface click, i think, only listen when pause is happened. And pause event can be triggered by some unwanted events, like buffering or tab switch, see #13
As alternative there is currently right click on Leader button for fast pause, long tap on touch devices, and alt-P hotkey.
We can put custom Pause button on page somewhere, but not sure how else to improve this situation.

@fosytherrac
Copy link
Author

Yes! This almost works great.
But this unfortunately only works with Pausing.

Is there a way to add it to also have the same function on pressing play?

@RblSb
Copy link
Owner

RblSb commented Mar 12, 2023

Unpause in this mode works for the person who paused it. But yea, i can maybe test additional option when evebody can unpause, if you still interested.

@fosytherrac
Copy link
Author

this would be very cool, i am sure this would improve the project even more! but dont stress about it. :)

@haveachin
Copy link

That you need to click the leader button before you can continue video playback is really annoying. Even a workaround for that would be great. requestLeaderOnPause is very nice though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants