Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: more quality choices #50

Open
89891383 opened this issue Mar 20, 2024 · 12 comments
Open

Plugin: more quality choices #50

89891383 opened this issue Mar 20, 2024 · 12 comments

Comments

@89891383
Copy link

Player: more quality choices. That is, for example, if I have the same video, but in several qualities, for example, from 360p to 1080p, then I add these links and every user can se choose the quality. Would you be able to do something like that, or at least such an add-on as a plug-in to SyncTube? I think this is a useful and cool option that would be worth using. I would like to see something like this.

@RblSb
Copy link
Owner

RblSb commented Mar 20, 2024

I think this should work for you
https://github.com/aNNiMON/SyncTube-QSwitcher

@89891383
Copy link
Author

I don't know much about how this works, can you help me with this? I put it in custom.js, and the files in the plugins folder, but I still don't know how to put two normal links with a different quality

@89891383
Copy link
Author

89891383 commented Mar 20, 2024

Something like this, that wants to add links with different names in the URL, that one is 720p and the other is 1080p, with the ending .mp4
If you would like to do something like that, that would be cool.

@aNNiMON
Copy link
Contributor

aNNiMON commented Mar 20, 2024

@89891383 that's exactly what SyncTube-QSwitcher does. You don't need to add all the links manually, only one would be enough.

So, for instance, you have prepared two files:
https://somesite/1_720p.mp4
https://somesite/1_1080p.mp4

You need to add only one of them to playlist:
https://somesite/1_1080p.mp4

Now, when this video starts playing, the plugin automatically determines that this file is 1080p and there's another file 720p, and it'll create a quality switcher.

Important

The filename pattern should exactly ends with: quality number + p.mp4, otherwise you'll need to adapt configs to match your URL pattern

@89891383
Copy link
Author

89891383 commented Mar 20, 2024

ok, and if I have let's say a video from an external site

and we have for example such a link, the first: https://example.com/example_480p.mp4
and the second link: https://example.com/example2_720p.mp4
then how to do it? @aNNiMON

@89891383
Copy link
Author

well there is also nowhere to switch this quality, there is no such option even pops up nowhere for me

@aNNiMON
Copy link
Contributor

aNNiMON commented Mar 20, 2024

@89891383 it should be the same filename except the quality number:
https://example.com/example_480p.mp4
https://example.com/example_720p.mp4

While in your case it's example_ and example2_, that's the problem.

@89891383
Copy link
Author

Well, can you do it as above? e.g. example2 or something, because it would be nice

@aNNiMON
Copy link
Contributor

aNNiMON commented Mar 20, 2024

@89891383 sure, if you provide more examples how the links are look like. Is it always file_480p, file2_720p, file3_1080p?

@aNNiMON
Copy link
Contributor

aNNiMON commented Mar 21, 2024

@89891383 that's completely different servers vwaw821 and vwaw525, ids 1711017117 and 1711017138, so it won't work automatically.

I think that's won't be solved without changes in SyncTube itself. We have two options:

  1. Ability to add video urls with a separator, URL1_1080||URL2_720||URL3_480
  2. Implement m3u8 support with source switches:
#EXT-X-STREAM-INF:PROGRAM-ID=1,RESOLUTION=854x480
URL3_480p.mp4
#EXT-X-STREAM-INF:PROGRAM-ID=1,RESOLUTION=1280x720
URL2_720p.mp4
#EXT-X-STREAM-INF:PROGRAM-ID=1,RESOLUTION=1920x1080
URL1_1080p.mp4

@RblSb what do you think?

@89891383
Copy link
Author

And a button to change the quality would also be useful. And it's so great that you replied quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants