Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Subscriber): Observer should just be an interface #224

Closed
benlesh opened this issue Aug 27, 2015 · 0 comments · Fixed by #225
Closed

refactor(Subscriber): Observer should just be an interface #224

benlesh opened this issue Aug 27, 2015 · 0 comments · Fixed by #225
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Aug 27, 2015

I think we could change Subscriber to be a class that extends Subscription and implements Observer rather than the other way around. Then Observer could just be an interface, and we can clean up some logic most likely.

The reason I suggest this is we never actually new up an Observer anywhere... whereas Subscription does get new-ed up and reused frequently. So it doesn't make as much sense to have Subscription be the one that is being used like an interface on Subscriber.

cc/ @trxcllnt

@benlesh benlesh self-assigned this Aug 27, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant