-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude src/ from published npm package #3334
Comments
I'm not entirely sure if it's accident to include bazel, what I vaguely remember is it is intended for ng build process. /cc @alexeagle for clarity. In any cases, at this point we don't officially support bazel-based build (as a build process of consumer application's build steps) yet, expect something might not work. |
@roblg Bazel is descending into the Just add
to your |
Thanks for the suggestion @alexeagle. I agree that that will work to fix this specific instance, but that doesn't really seem like a long-term solution. (I'd hate to have to randomly go add things to our WORKSPACE that happen to end up in node_modules during local development. What happens if we get a dependency conflict, and we end up with two copies in node_modules?). From our perspective, rxjs isn't a bazel dependency at all, it's just an npm package that we depend on (transitively) that happens to contain its I'm not super familiar with this project (it's only a transitive dependency of... something. I'm not even sure what yet... 😬). Is there a reason that it ships If |
I've discussed with @benlesh about switching rxjs off the package.json scripts and onto Bazel. I think as part of that, we should change the model for how Bazel users get rxjs - they should have a WORKSPACE dep on the rxjs source tree, not on the npm published package. One problem is version skew - we don't have a good way for npm to fetch version 6.0.0 for example, while making sure that Bazel WORKSPACE doesn't fetch 6.0.1. I need to find some time to use https://github.com/pubref/rules_node and understand it better, then maybe discuss with @pcj |
src/ is being used for source maps |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RxJS version:
At least version 5.5.6
Expected behavior:
src/
folder (in particular, the BUILD.bazel file) is excluded from published npm package.Actual behavior:
src/
folder including BUILD.bazel file is included in published npm package, and gets picked up by our bazel in node_modules (we're currently using bazel primarily for Java, and not yet for JS for development):Additional information:
Love that you're using bazel in an open source JS project! <3 Bazel.
The text was updated successfully, but these errors were encountered: