Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make :StartReview command auto-detect the PR number #15

Open
ReeceStevens opened this issue Sep 21, 2022 · 0 comments
Open

Make :StartReview command auto-detect the PR number #15

ReeceStevens opened this issue Sep 21, 2022 · 0 comments
Milestone

Comments

@ReeceStevens
Copy link
Owner

Currently, to start a review you have to manually provide the PR number. This shouldn't be necessary since we have the remote URL and the branch name.

Requirements:

  1. First time :StartReview without arguments is used on a branch, query GitHub API for open PRs for this branch. If only one, auto-select and print the PR number used as a message. If more than one (e.g. different base branches), print all options and wait for user input to select which one.

  2. For future usages of :StartReview without arguments, check the local review files first to find any ongoing review for this branch. Same rules for single or multiple apply.

  3. If no matching local reviews are found, AND the GH API is inaccessible (e.g. offline review), prompt the user for a PR number to be manually entered.

@ReeceStevens ReeceStevens added this to the MVP milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant