Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ic violation produces huge output of blank lines using --format pretty (the default) #29

Open
cpetitpas opened this issue Aug 16, 2022 · 8 comments · Fixed by #30
Open

Comments

@cpetitpas
Copy link

After the merge of RelationalAI/rai-cli#17, it seems that rai-cli default output for an ic violation (pretty) produces /:abort and then a huge number of blank lines.....and seems to not terminate.
Issue does not occur using --format json and did not occur before the merging of RelationalAI/rai-cli#17.

Example Rel:

//ic violation type int/float
def my_data = {3.14}

ic myDataExists(x) = my_data(x) implies Int(x)

cc: @vilterp / @NRHelmi / @NHDaly

@NHDaly
Copy link
Member

NHDaly commented Aug 16, 2022

My guess is that it's getting stuck on pretty-printing the abort = true relation, which has empty arrow data.

The Julia SDK had a similar issue, fixed here: RelationalAI/rai-sdk-julia#65

@NHDaly
Copy link
Member

NHDaly commented Aug 16, 2022

I will transfer this issue to the Golang SDK, since that's where the pretty printing functionality is implemented.

@NHDaly NHDaly transferred this issue from RelationalAI/rai-cli Aug 16, 2022
@cpetitpas
Copy link
Author

Thank you @NHDaly .

@cpetitpas
Copy link
Author

After pull, ./tidy, and ./make in rai-cli, the original ic violation issue has returned. Additionally the load_binary issue has returned.
The String and missing issues detailed in #30 (comment) are as described there so it seems we have a partial merge of the fix.

@cpetitpas cpetitpas reopened this Aug 19, 2022
@NRHelmi
Copy link
Contributor

NRHelmi commented Aug 19, 2022

Currently latest is v0.3.0-alpha in pkg.go.dev
Let's wait for last tag v0.3.1-alpha to get propagated 🙏

@cpetitpas
Copy link
Author

Thanks @NRHelmi .
So I guess that doesn't occur on merge? How do we know when that occurs? I tried manually changing go.mod to use v0.3.1-alpha but it couldn't find it.

@NRHelmi
Copy link
Contributor

NRHelmi commented Aug 19, 2022

@cpetitpas yep we still need to create tags manually, similar to release we still control them manually usually when a new feature is added or a user requests a new release 🙏 to be honest I wasn't following how much time it would take to propagate a new version the pkg.go.dev.

Yeah probably you won't be able to use the new version unless it is indexed pkg.go.dev side, sorry for that 🙏

@billscheidel-rai
Copy link

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-6430.

This link is only accessible to employees of RelationalAI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants