Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the negative delta guards #2577

Closed
hhyyrylainen opened this issue Sep 6, 2021 · 5 comments
Closed

Check the negative delta guards #2577

hhyyrylainen opened this issue Sep 6, 2021 · 5 comments

Comments

@hhyyrylainen
Copy link
Member

Just got notice that this was merged: godotengine/godot#35617
so maybe it is time to check if we can soon remove the negative delta guards in our code.

@nathanfranke
Copy link

nathanfranke commented Sep 6, 2021

That PR was not cherry-picked for 3.3 or 3.x so you will only get the changes after updating to Godot 4.0 or later

Edit: It does have the cherry-pick label, so it might be available in 3.4

@hhyyrylainen
Copy link
Member Author

Now that we use 3.4 this seems like it's time to re-check this. I think I saw in the patch notes that negative frame delta is finally fixed

@RacerBG
Copy link
Contributor

RacerBG commented Dec 1, 2021

Now that we use 3.4 this seems like it's time to re-check this. I think I saw in the patch notes that negative frame delta is finally fixed

That's correct, it is fixed in 3.3.4: "Manuel Moos (zmanuel) also implemented a fix for occasional negative frame deltas due to getting out of sync with the OS clock."

@hhyyrylainen hhyyrylainen added this to the Release 0.6.7 milestone May 22, 2024
@hhyyrylainen
Copy link
Member Author

It's probably safe to remove the negative delta guards now from everywhere, so this is pretty easy to do. Though I'd keep at least one check in the world simulation class to have some kind of detection if this ends up happening.

@hhyyrylainen
Copy link
Member Author

Looks like the delta guards have been removed so I think it is finally time to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants