-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the negative delta guards #2577
Comments
That PR was not cherry-picked for 3.3 or 3.x so you will only get the changes after updating to Godot 4.0 or later Edit: It does have the cherry-pick label, so it might be available in 3.4 |
Now that we use 3.4 this seems like it's time to re-check this. I think I saw in the patch notes that negative frame delta is finally fixed |
That's correct, it is fixed in 3.3.4: "Manuel Moos (zmanuel) also implemented a fix for occasional negative frame deltas due to getting out of sync with the OS clock." |
It's probably safe to remove the negative delta guards now from everywhere, so this is pretty easy to do. Though I'd keep at least one check in the world simulation class to have some kind of detection if this ends up happening. |
Looks like the delta guards have been removed so I think it is finally time to close this issue. |
Just got notice that this was merged: godotengine/godot#35617
so maybe it is time to check if we can soon remove the negative delta guards in our code.
The text was updated successfully, but these errors were encountered: