Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for untrusted sources? #16

Open
LPGhatguy opened this issue Mar 2, 2020 · 0 comments
Open

Warn for untrusted sources? #16

LPGhatguy opened this issue Mar 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@LPGhatguy
Copy link
Contributor

It might be possible for a project using Foreman to replace a commonly used tool like Rojo with a binary from a different source that could be malicious.

Do we think it's a concern that running rojo in a freshly-cloned directory could execute arbitrary code?

One possible guard would be needing to 'trust' any new source that tools are downloaded from. The first time a user tries to run a tool from rojo-rbx/rojo, Foreman would ask if it's okay.

On CI machines, we could add a flag like --always-trust-sources that lets us bypass this prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant