Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve artifact detection #3

Closed
2 of 3 tasks
LPGhatguy opened this issue Feb 12, 2020 · 1 comment
Closed
2 of 3 tasks

Improve artifact detection #3

LPGhatguy opened this issue Feb 12, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@LPGhatguy
Copy link
Contributor

LPGhatguy commented Feb 12, 2020 •
edited
Loading

Foreman currently assumes you're on Windows and assumes artifacts are zip files with win64 in their name somewhere and only one file. This doesn't hold up for projects that aren't mine, mostly.

We should support:

  • Other platforms... at all
  • Artifacts with different platform names
    • windows, win32, win64 for Windows
    • macos, darwin for macOS
    • linux for Linux?
  • Artifacts with different structure
    • plain binaries
    • zip files with more than one file in them
@LPGhatguy LPGhatguy added the enhancement New feature or request label Feb 12, 2020
@LPGhatguy
Copy link
Contributor Author

I think this issue is mostly wrapped up. Further work can be done in #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LPGhatguy