Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist name header pushes out downvote icon sometimes #2

Open
eyebraus opened this issue May 31, 2014 · 3 comments
Open

Artist name header pushes out downvote icon sometimes #2

eyebraus opened this issue May 31, 2014 · 3 comments
Labels

Comments

@eyebraus
Copy link
Member

At my browser's width, the length of this artist's name was causing the downvote icon to be shoved below it. Because I'm a derp I didn't dig into the root cause of it, but I'm guessing the three elements (upvote, title, downvote) are floated siblings and the header width isn't fixed.

screen shot 2014-05-31 at 11 12 36 am

@eyebraus eyebraus added the bug label May 31, 2014
@clehner
Copy link
Member

clehner commented Jun 2, 2014

I agree, this doesn't look great. @stevenleeg, do you think we should make the artist name fixed width?

@stevenleeg
Copy link
Member

I attempted to address this bug on c79a4a6, but it appears that wasn't enough (I've experienced this issue as well).

I think there are two ways we can solve this: the turntable way of basically implementing marquee for longer artist names or reducing the font size of the artist based on the length of the artist name.

Personally I think the former is a better approach, as it would scale to ridiculously named artists better than the latter approach. I can add this to my list of todos when I get some free time.

@eyebraus
Copy link
Member Author

eyebraus commented Jun 2, 2014

I agree that the marquee approach would probably be best here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants