Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper support for right-to-left languages #1214

Closed
gmsecrieru opened this issue Oct 22, 2015 · 9 comments
Closed

Add proper support for right-to-left languages #1214

gmsecrieru opened this issue Oct 22, 2015 · 9 comments

Comments

@gmsecrieru
Copy link
Contributor

For example:
screen shot 2015-10-22 at 18 33 47

@engelgabriel
Copy link
Member

@shahar3012 can you still help us with that?

@fduraibi
Copy link
Contributor

@engelgabriel What kind of help do you need?

@engelgabriel
Copy link
Member

@fduraibi Test the system in a right-to-left language and tell us if there is anything broken o not property aligned.

@fduraibi
Copy link
Contributor

Here is the result from the first test:

1- Fix direction of the user status, should be rtl instead: FIXED

.account-box .options > .wrapper {
    direction: ltr;
}

2- The markdown formatting-tips is not aligned correctly and covers the "user typing" status, should be aligned to the left side FIXED
3- Upload Icon need to be flipped FIXED
4- The text area Message should be on the right side (dir="auto" need to be changed to dir="rtl", since auto keeps it on the left even when using Arabic word instead of Message) FIXED
5- The flex-tab-bar is totally missing in Arabic interface FIXED
6- Allow using Arabic (non-English) to display names of users and rooms!! Can be done using UTF8 regex from Admin menu

rocketchat-bug4

@fduraibi
Copy link
Contributor

7- Fix alignment of message starring: FIXED
rocketchat-bug5

@fduraibi
Copy link
Contributor

fduraibi commented Dec 1, 2015

8- Other fixes need to be done in the Administration pages, e.g. room management: FIXED

rocketchat-bug7

  • Missing name is a bug that happened after I renamed one of the rooms. The room was created with an english name, then I enabled using Arabic characters in the UTF8 regex, renamed the room to an arabic name, it accepted the name but it disappeared! (see picture below also)
    rocketchat-bug8
  • This is on a fresh installed server with latest updates

@fduraibi
Copy link
Contributor

fduraibi commented Dec 4, 2015

All of the listed problem are fixed in #1538 or #1569

Except the last problem of missing room name, but that is more of a general bug and doesn't seem to be RTL related.

@engelgabriel I suggest closing this issue.

@engelgabriel
Copy link
Member

Does the room name goes missing only on after renaming? If you create it properly it shows ok, right?

@engelgabriel
Copy link
Member

Closed, and the remaining issue was created #1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants