Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL_DISABLE_WINDOWS_IME #1041

Closed
uhuntu opened this issue Nov 26, 2020 · 3 comments
Closed

SDL_DISABLE_WINDOWS_IME #1041

uhuntu opened this issue Nov 26, 2020 · 3 comments
Labels
build-process Everything related to build.rs, or the build process in general

Comments

@uhuntu
Copy link
Contributor

uhuntu commented Nov 26, 2020

Do you want to #define SDL_DISABLE_WINDOWS_IME in src/video/windows/SDL_windowskeyboard.c to workaround the IME issue on Windows ? As I see there are many struggles in https://bugzilla.libsdl.org/show_bug.cgi?id=3421, but the owner of SDL seems do not have any thoughts to figure it out finally as Windows limitation even GLFW can not either. glfw/glfw#41

As the discussion in https://discourse.libsdl.org/t/can-i-use-sdl-disable-windows-ime-and-ignore-other-input-at-the-same-time-without-hacks/24468, I thought SDL_DISABLE_WINDOWS_IME should be a quick fix for CJK people. Especially for the application like https://github.com/Kethku/neovide @aclysma @Kethku
@Cobrand
Copy link
Member

Cobrand commented Nov 26, 2020

Since it seems it's an "intentional" bug for now (given it's written as FIXME), I am okay with creating a patch that fixes this issue under sdl2-sys/patches/.

Just link to this issue in the comments so that we know what it's for and when we should remove it.

However after browsing the neovide repository, it seems that #1029 is blocking them to upgrade to 0.34.3 with bundled, so you may have to take that into account.

@Cobrand Cobrand added the build-process Everything related to build.rs, or the build process in general label Nov 26, 2020
This was referenced Nov 30, 2020
Merged
Merged
@uhuntu
Copy link
Contributor Author

uhuntu commented Dec 2, 2020

I know @aclysma had some commits that fixed mac issue, and see my comment here #1029 (comment)

@Cobrand
Copy link
Member

Cobrand commented Dec 2, 2020

Closed by #1042

@Cobrand Cobrand closed this as completed Dec 2, 2020
@bryanedds bryanedds mentioned this issue Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-process Everything related to build.rs, or the build process in general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uhuntu @Cobrand